fix: turn off audit feature #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanseto
approved these changes
Jul 16, 2024
johanseto
reviewed
Jul 16, 2024
| @@ -220,6 +220,7 @@ class ResultNotificationBackend(RealTimeImport): | |||
| for handling result notifications, including extracting result notification data, | |||
| retrieving enrollment information, and generating external certificates. | |||
| """ | |||
| use_audit_backend = False | |||
There was a problem hiding this comment.
Do you thinks is not important to audit ResultNotificationBackend
There was a problem hiding this comment.
I think that is important but it's not possible, anyway, the certificate has its own audited method so we won't be able to audit the whole pipeline but we will get the same current behavior for external certificates
There was a problem hiding this comment.
With the externalCertificates behavior is enough by the moment.
andrey-canon
force-pushed
the
and/add_detail_view_to_result_notification
branch
from
5cfa74a
to
aebfe51
Compare
andrey-canon
changed the base branch from
and/add_detail_view_to_result_notification
to
master
andrey-canon
force-pushed
the
and/fix_result_notification_backend
branch
from
bad261a
to
3036716
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deactivate audit process, since the backend has data that is not serializable
Before
After
Additional information
Include anything else that will help reviewers and consumers understand the change.
Checklist for Merge